Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for destroy_scheduled_duration #109

Merged
merged 7 commits into from
Nov 3, 2023
Merged

feat: add support for destroy_scheduled_duration #109

merged 7 commits into from
Nov 3, 2023

Conversation

chrisw-tracer
Copy link
Contributor

We had a requirement to override the default 24 hour deletion schedule period. I know this default is changing to 30 days next year but thought this might be useful to others in the mean time.

@chrisw-tracer chrisw-tracer requested a review from a team as a code owner November 1, 2023 18:26
@google-cla Google CLA
Copy link

google-cla bot commented Nov 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chrisw-tracer
Copy link
Contributor Author

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

I've completed the CLA

@chrisw-tracer
Copy link
Contributor Author

@apeabody any feedback on this PR?

apeabody
apeabody requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @chrisw-tracer!

variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@apeabody apeabody mentioned this pull request Nov 3, 2023
Merged
@apeabody
Copy link
Contributor

apeabody commented Nov 3, 2023

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Nov 3, 2023

/gcbrun

@apeabody apeabody merged commit c26f3fb into terraform-google-modules:master Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisw-tracer @apeabody